ObjectManagerManager / SMAPIDedicatedServerMod

Dedicated (headless) server mod for Stardew Valley, powered by SMAPI. Turns the host into an automated bot.
MIT License
78 stars 17 forks source link

Crops survive when they finish growing on the first day of the incompatible season #10

Closed ObjectManagerManager closed 1 year ago

ObjectManagerManager commented 1 year ago

When a crop enters an incompatible season, it should only be saved if it was harvestable immediately prior to going out of season. This isn't the case, currently.

A fix would be to mark the crop for death in the morning when two conditions are satisfied: 1) It has existed in an incompatible season in the past, possibly including this morning 2) The previous night, the crop was not ready for harvest

If 1) occurs but not 2), then the crop doesn't need to be marked for death at any point in the future---the crop will be marked to allow one more harvest, and it'll be removed instantly when harvested next. It's already harvestable, and so 2) can't be satisfied without the crop being harvested again, at which point it'll be removed anyway. If 1) does not occur, then nothing should happen. If they both occur, then the crop should be marked for death.