ObjectPascal-Community / 1brc-ObjectPascal

1️⃣🐝🏎️ The 1 Billion Row Challenge in Object Pascal
MIT License
54 stars 22 forks source link

refactor: Change CompareStr for sorting to use the one from AnsiStrings. #86

Closed corneliusdavid closed 7 months ago

corneliusdavid commented 7 months ago

different hash but still wrong. :-(

gcarreno commented 7 months ago

Hey David(@corneliusdavid),

@georges-hatem was able to solve the compare issue using System.AnsiStrings.CompareStr to match the hash.

https://github.com/gcarreno/1brc-ObjectPascal/blob/6745da028756f59ce4f7954714aa23550c5eecc6/entries/ghatem/src/OneBRC.pas#L193

Wanna have a go at that one and I'll wait?

Cheers, Gus

gcarreno commented 7 months ago

Hey David(@corneliusdavid),

And I think he also never touches anything Unicode up til he has to output. Uses ANSI for everything. Especially the comparison is made in ANSI.

Cheers, Gus