search

ObjectProfile / Roassal3

The Roassal Visualization Engine
MIT License
95 stars 52 forks source link

[WIP] Change announcement api #521

Closed PalumboN closed 1 year ago

PalumboN commented 1 year ago

We changed the Announcement API

when: event do: action

by

when: event do: action for: subscriber

See https://github.com/pharo-project/pharo/pull/13270 for more details

akevalion commented 1 year ago

Some error in this PR

PalumboN commented 1 year ago

There are no real errors (I guess, there are many methods without tests). We need to merge the Pharo PR first and merge dependencies later.

PalumboN commented 1 year ago

@akevalion I fixed the problem :)

I left the old methods when:do: as deprecated (same as Pharo) it's safer.

Tell me if you still have problems with this change in Pharo12

akevalion commented 1 year ago

Thanks I will test it