ObjectProfile / Roassal3

The Roassal Visualization Engine
MIT License
95 stars 52 forks source link

Use the right API about protocol #549

Closed jecisc closed 1 year ago

jecisc commented 1 year ago

CompiledMethod>>protocol should return a real protocol (and will soon) so the code that needs a protocol name should use #protocolName

The change is planed for really soon, could we have a Pharo12 branch of Roassal so that this kind of changes make it fast into the image or could there be a release soon with this change in it? (I wanted to try to do this change this week but I didn't see that we had one use in Roassal)

jecisc commented 1 year ago

protocolName exists only in Pharo 12. How is roassal managed on this aspect? Is there a branch build for the Pharo integration?

akevalion commented 1 year ago

For older versions, in roassal in the baseline I add packageRoassal3-Pharo9 with missing methods for compatibility In this case we can modify the baseline and add a new package Roassal3-Pharo11 And the baseline will load this package with extension methods of the missing code.

akevalion commented 1 year ago

I have added Roassal3-Pharo package, that contains new code used in pharo12 but not in older pharo's, then this should work on pharo8,9, 10, 11, and 12

akevalion commented 1 year ago

Please create an issue in pharo to create a new release of roassal and asing that to me.