Thinkthrough needed for countries that are in multiple continents

ObjectVision / NetworkModel_World

GNU General Public License v3.0

0 stars 0 forks source link

Thinkthrough needed for countries that are in multiple continents #21

Closed cjacobscrisioni closed 9 months ago

cjacobscrisioni commented 9 months ago

Weird results in Turkey, crash in Russia.

Turkey is ran as a country in Asia but the network is in Europe. Straightforward change.
The network in Russia is split between the European and the Asian part with a slight overlap, but not full overlap. This may need prior editing.

cjacobscrisioni commented 9 months ago

Russia is currently considered fully European. The Continents definition boundaries seem to coincide fairly well with the break in OSM networks coverage

cjacobscrisioni commented 9 months ago

Moved Turkey to Europe using the Continents_edit attribute in local_units. See push a30bbee..3459649

cjacobscrisioni commented 9 months ago

Russia is currently considered fully European. The Continents definition boundaries seem to coincide fairly well with the break in OSM networks coverage

Probably best to split Russia in a European and Asian part. This does impose a constraint on catchments and FRAs, but a defendable one.

cjacobscrisioni commented 9 months ago

Alas the Asia - Europe divide in Russia according to GADM does not coincide with the confines of the OSM data

jipclaassens commented 9 months ago

hack verzinnen om een stukje extra rusland toe te voegen?

cjacobscrisioni commented 9 months ago

Just pushed a solution - I am now dividing Russia into two parts, with regional units being assigned to Asia or Europe depending on which continental network has the most links in a regional unit. This is a bit slow but the processing data is unlinked from the regional unit generation processes so should be fine (does require recomputation of all the unlinked data though)