ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.
https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
Other
38 stars 2 forks source link

Better Error Handling #11

Closed ObliviousHarmony closed 3 years ago

ObliviousHarmony commented 3 years ago

All Submissions:

Changes proposed in this Pull Request:

Rather than silently logging errors to the console we should notify the user when PHPCS fails and create a channel for them to respond to the error feedback. This PR adds a new output channel for the extension as well as a notification that informs them of the error.

How to test the changes in this Pull Request:

  1. Use an invalid phpCodeSniffer.executable option like sleep that will fail
  2. Ensure that the error is rendered to the output channel.