ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.
https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
Other
40 stars 2 forks source link

Diagnostics Not Erased On Configuration Or FileSystemWatcher Changes #72

Closed ObliviousHarmony closed 11 months ago

ObliviousHarmony commented 1 year ago

Description

When the user makes a change to their configuration, the executable, or their coding standard file, we should clear any existing diagnostics. It's very possible that these have become invalid, so, while the linter is running, they should not see potentially invalid diagnostics.

Reproduction Steps

  1. Make one of the above changes.
  2. Note that the diagnostics are not erased.

Expected Behavior

Diagnostics should be cleared when there is a meaningful change to the possible results of the diagnostics search.