Possible Worker Race Conditions

ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.

Other

40 stars 2 forks source link

Closed ObliviousHarmony closed 11 months ago

ObliviousHarmony commented 1 year ago

If the worker completes after the document is closed, does the worker set diagnostics for the document that isn't present?
Since only the worker sets the diagnostics, what happens if the worker completes and doesn't throw the cancellation error, but, the request was cancelled? It should not do anything if it completes and the request was cancelled.

No clue!

There shouldn't be any race conditions.

ObliviousHarmony commented 11 months ago

It does not look like these race conditions exist.