ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.
https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
Other
40 stars 2 forks source link

Clear Diagnostics On Unacceptable Exceptions #79

Closed ObliviousHarmony closed 11 months ago

ObliviousHarmony commented 11 months ago

All Submissions:

Changes proposed in this Pull Request:

We should be clearing diagnostic information when we throw exceptions that we did not accept. This prevents some diagnostics to be left behind when they shouldn't be.

Closes #71.

How to test the changes in this Pull Request:

  1. Open a project with a working PHPCS extension configuration.
  2. Make sure that there are visible errors in a document.
  3. Break the configuration, such as by turning off autoExecutable and entering an invalid executable.