ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.
https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
Other
38 stars 2 forks source link

Ensure Worker Always Freed #81

Closed ObliviousHarmony closed 10 months ago

ObliviousHarmony commented 10 months ago

All Submissions:

Changes proposed in this Pull Request:

When the worker resolved early the pool was not getting informed of the completion. We need to make sure that it gets freed correctly so that the pool does not get exhausted and the status does not break.

Closes #76.

How to test the changes in this Pull Request:

  1. Open a project with linting disabled.
  2. Turn on automatic executable discovery but keep standard set to disabled.
  3. Try linting a file, it should not hang at all.
  4. Set a standard, make sure it works.
  5. Clear the setting again and make sure it still doesn't work.