search

ObliviousHarmony / vscode-php-codesniffer

A VS Code extension for integrating PHP_CodeSniffer.
https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
Other
38 stars 2 forks source link

Loosened Some Configuration Scopes #90

Closed ObliviousHarmony closed 7 months ago

ObliviousHarmony commented 7 months ago

All Submissions:

Changes proposed in this Pull Request:

I made an incorrect assumption that "window" applied to each individual folder in a multi-root workspace. This is not true and the scope that achieves that should be "resource". This PR changes the scope on some of those settings.

Closes #88.

How to test the changes in this Pull Request:

  1. Make sure that the extension still works as-is.
  2. Check that the extension works in a multi-root workspace and uses the correct PHPCS and configuration.