ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
195 stars 84 forks source link

Deneb design doc #1900

Closed xenowits closed 1 year ago

xenowits commented 1 year ago

🎯 Problem to be solved

The next ethereum consensus layer fork after capella is named deneb. This upgrade adds proto-danksharding, ie, EIP-4844 to the beacon chain.

We want charon to be ready for deneb.

🛠️ Proposed solution

Write a design document to understand what changes are needed in charon to support the deneb hardfork.

🧪 Tests

We should test charon to ensure it works properly before the deneb fork comes around, which is tentatively on 12th April, 2023.

corverroos commented 1 year ago

@gsora the first step would to look at the new endpoints and verify that we will be able to add them either without changes or whether the proposed endpoints are not compatible with middleware DVT and would require additional changes.

gsora commented 1 year ago

I see no explicit new endpoints added in Deneb by the looks of the linked PR, as of today.

There are new/modified objects though: the BlockContent definition changed to accomodate sidecars.

gsora commented 1 year ago

Looking at the PRs on the beacon API repo, there's this: https://github.com/ethereum/beacon-APIs/pull/286

gsora commented 1 year ago

As @dB2510 mentioned, the consensus spec mentions a new domain: https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/validator.md#constructing-the-signedblobsidecars

dB2510 commented 1 year ago

Just mentioning here for the record, we should participate in devnet 5 of deneb upgrade this week to understand how it will us affect directly. If there are some changes in deneb spec that we need to propose in order to support deneb with charon then we should communicate those asap with core devs since it is still in development phase. For more details: https://www.galaxy.com/research/insights/ethereum-all-core-developers-consensus-call-107/ https://hackmd.io/@inphi/HJZo4vQGn

cc: @gsora

boulder225 commented 1 year ago

running charon in the deneb testnets and getting charon passing the deneb hive tests

gsora commented 1 year ago

We need to extend compose to execute a full Eth2 local network, with our custom genesis etc.

dB2510 commented 1 year ago

Here's the requirements doc for deneb upgrade: https://docs.google.com/document/d/1WcJ4P-_JO937biy4nzwrYyWrYapldiTlAyOQU0qoCo0/edit

xenowits commented 1 year ago

The protocol team has agreed on implementing the solution 2 as mentioned in the doc as it is simple and easy to implement.