ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client

https://docs.obol.tech/

Other

176 stars 83 forks source link

Fix Sigma Prime Audit Results #1991

Closed corverroos closed 1 year ago

corverroos commented 1 year ago

🐞 Bug Report

Description

Sigma Prime has completed the charon audit, see report and tracking sheet.

Larger issues probably need their own github issues, but smaller issues can be directly linked to this issue.

[x] #1997

gsora commented 1 year ago

After reviewing all the panic() usage in our codebase, we're going to mark OBOL-08 as WONTFIX: they are only used in code paths that must never happen, hence it makes sense for us to stop the execution and report the error.

gsora commented 1 year ago

We're marking OBOL-09 as WONTFIX: as the report says, fixing OBOL-02 makes sure Charon never falls into the potentially panicking Kryptology code path outlined.