search

ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
177 stars 83 forks source link

*: not https warning to show only on http #3124

Closed KaloyanTanev closed 3 months ago

KaloyanTanev commented 3 months ago

A warning log was output in the case "https" is missing as a scheme. This triggered anytime it was not https, even if the scheme was empty.

Linter complained for repeated "http", so I've moved it to const alongside "https".

category: misc ticket: none

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (ed1d55a) to head (0f0833a). Report is 3 commits behind head on main.

Files Patch % Lines
cmd/run.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3124 +/- ## ========================================== - Coverage 56.77% 56.74% -0.03% ========================================== Files 208 208 Lines 29305 29305 ========================================== - Hits 16637 16630 -7 - Misses 10831 10835 +4 - Partials 1837 1840 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.