ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
202 stars 90 forks source link

cmd: beacon node API timeouts #3164

Closed gsora closed 4 months ago

gsora commented 5 months ago

Add two CLI flags for run:

Both flag default to the previous 2 seconds timeout.

category: feature ticket: none

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (82d6f70) to head (b15f7dd).

Files Patch % Lines
app/app.go 0.00% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3164 +/- ## ========================================== + Coverage 56.65% 56.68% +0.02% ========================================== Files 208 208 Lines 29202 29216 +14 ========================================== + Hits 16545 16561 +16 Misses 10828 10828 + Partials 1829 1827 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gsora commented 5 months ago

I'll wait for protocol team's review before merging.

Thanks for your help on the CLI arguments copy!