ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
202 stars 89 forks source link

testutil/integration: fix nightly test behavior #3343

Closed gsora closed 1 month ago

gsora commented 1 month ago

Instead of passing errors around with channels, which in this specific test might alter timings, just panic when error is not of "context canceled" kind, during the induced restart phase.

Not ideal, but simple and effective.

category: bug ticket: none

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.69%. Comparing base (774902f) to head (2288df2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3343 +/- ## ======================================= Coverage 58.68% 58.69% ======================================= Files 210 210 Lines 30290 30290 ======================================= + Hits 17777 17779 +2 + Misses 10621 10617 -4 - Partials 1892 1894 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.