Closed gsora closed 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Looks like we will need to create a release-v1.1.2 branch, update app version there and then PR into that branch instead of main-v1.1? or is it fine to directly PR to main-v1.1? I am confused what we allow and what not :)
If you look at the history of main-v1.1
, when we released v1.1.1 we simply pushed a new commit on that branch.
Github actions will take care of fixing the version string at compile time.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.70%. Comparing base (
dc848df
) to head (56bab9b
). Report is 1 commits behind head on main-v1.1.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If you look at the history of
main-v1.1
, when we released v1.1.1 we simply pushed a new commit on that branch.Github actions will take care of fixing the version string at compile time.
Thank you for clarifying!
Manually merging to kick the v1.1.2 tag down the line.
Recent DKG issues may be due to an issue in bls-eth-go-binary, caused by an upstream bug in their dependencies.
Update to v1.36.1 which solves the issue.
Reference: https://github.com/herumi/bls-eth-go-binary/issues/63
category: bug ticket: none