ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
201 stars 89 forks source link

*: update bls-eth-go-binary #3349

Closed gsora closed 1 month ago

gsora commented 1 month ago

Recent DKG issues may be due to an issue in bls-eth-go-binary, caused by an upstream bug in their dependencies.

Update to v1.36.1 which solves the issue.

Reference: https://github.com/herumi/bls-eth-go-binary/issues/63

category: bug ticket: none

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pinebit commented 1 month ago

Looks like we will need to create a release-v1.1.2 branch, update app version there and then PR into that branch instead of main-v1.1? or is it fine to directly PR to main-v1.1? I am confused what we allow and what not :)

gsora commented 1 month ago

If you look at the history of main-v1.1, when we released v1.1.1 we simply pushed a new commit on that branch.

Github actions will take care of fixing the version string at compile time.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.70%. Comparing base (dc848df) to head (56bab9b). Report is 1 commits behind head on main-v1.1.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main-v1.1 #3349 +/- ## ============================================= - Coverage 57.74% 57.70% -0.04% ============================================= Files 211 211 Lines 30398 30398 ============================================= - Hits 17552 17540 -12 - Misses 10965 10972 +7 - Partials 1881 1886 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pinebit commented 1 month ago

If you look at the history of main-v1.1, when we released v1.1.1 we simply pushed a new commit on that branch.

Github actions will take care of fixing the version string at compile time.

Thank you for clarifying!

gsora commented 1 month ago

Manually merging to kick the v1.1.2 tag down the line.