ObolNetwork / helm-charts

Obol's Helm Charts
1 stars 4 forks source link

Is the release name semantic versioning/consistent for helm charts? #13

Closed OisinKyne closed 1 year ago

OisinKyne commented 1 year ago

Problem to be solved

charon-0.1.0 is not a semantic versioning release name I'm familiar with, is this the standard release convention for helm charts? I'm not sure it is.

Proposed solution

Opt for a release naming convention that works well for helm and is aligned as much as possible with other ways we version our repos.

aly-obol commented 1 year ago

@OisinKyne apparently the helm-release github action automatically creates the release version using the chartname-semver, I guess the GA assumes that the repo has multiple charts with different releases cycles. I will check if it is possible to change this behavior.

And yeah, this versioning is not common but still standard for mono repos releases, but at the same time for the published chart the standard is without the chart name, and luckily this is what the CI workflow published to the artifactory: https://artifacthub.io/packages/helm/charon/charon

aly-obol commented 1 year ago

I doubled checked it, and it is the standard helm-release way when the repo has multiple charts then we can have a different release cycle for each chart. Helm promotes this approach through their helm-releaser github action. I lean towards this versioning over using a single version for all charts in the repo.