search

Obsidian-StudiosInc / ecrire

General purpose graphical Text Editor built on the Enlightenment Foundation Libraries (EFL)
GNU General Public License v3.0
7 stars 1 forks source link

Crash on deleting spaces #7

Closed NuLogicSystems closed 7 years ago

NuLogicSystems commented 7 years ago

When editing a line that has too many spaces before the first character with either the delete key, or with the backspace key, crashes ecrire with no warning and on random number of deletes.

wltjr commented 7 years ago

Thanks, not sure if that is an elm code issue or ecrire. Likely elm code unless something with ecrire callbacks is causing an issue. I will see if I can replicate.

wltjr commented 7 years ago

Can you see if this remains with EFL 1.19.1? I am not able to replicate. If it does still occur. Can you provide reproducible steps? Thanks!

NuLogicSystems commented 7 years ago

It's random, let me see if I can record it.

wltjr commented 7 years ago

Ok no problem. Also see if you can replicate with Elementary test. That will confirm if its elm code or ecrire specific. Thank you!

NuLogicSystems commented 7 years ago

I've tried vokoscreen, recordmydesktop and simple screen recorder. I can't seem to capture the desktop, I just get a bunch of flickering apps on the desktop.

NuLogicSystems commented 7 years ago

OK, I had vsync turned on in the compositor that was interfering with recording.. https://www.dropbox.com/s/z1p4oswavva6sfv/vokoscreen-2017-05-22_18-57-28.mp4?dl=0 https://www.dropbox.com/s/hcpymnvehz9o4vf/vokoscreen-2017-05-22_18-59-15.mp4?dl=0

NuLogicSystems commented 7 years ago

What test in elm test would I use to test this issue?

wltjr commented 7 years ago

In Elementary test app the search box, type in code. There are 3, Code Editor, Code Entry Markup, and Code Syntax. Usually it will occur in the first, Code Editor. That is the one I use the most, but should occur in any of the 3.

wltjr commented 7 years ago

Ah ok I was able to replicate with your videos. Seems the key to trigger is make sure the cursor is at the very start of the line. I was able to replicate once with elementary test as well. I cannot reliable replicate in the tests as I can in ecrire. Not sure what that means yet.

wltjr commented 7 years ago

Opened upstream task T5516

wltjr commented 7 years ago

@NuLogicSystems is this still occurring for you using EFL 1.20.0 beta 3? I am no longer getting crashes. This may be resolved in EFL 1.20 release. Thanks for time checking!

NuLogicSystems commented 7 years ago

I'm still getting crashes adding text in some of my files, but not in deleting any text in the same files. I'm not sure if this answer helps, or not.

NuLogicSystems commented 7 years ago

Oops, spoke too soon. It just crashed on me when deleting text. This file usually crashes on me: https://www.dropbox.com/s/aase4h6azwxz182/PKGBUILD.txt?dl=0

wltjr commented 7 years ago

Adding text would be a new issue or related to the deleting spaces maybe. Likely a new issue. I will check out that file thanks. I was using the other big file you provided before. It just hangs on that one for me now, till it runs out of memory and crashes. I commented on the phab bug.

wltjr commented 7 years ago

I opened a new issue T5771 for the crash adding text. Likely need to open one here as well. I had opened another upstream I did not here T5504, crash when pressing enter on long lines. I think the issue with crashing on characters is related. At least seems to be for me.

wltjr commented 7 years ago

Seems both these were resolved in 1.20.1. Can you confirm?

NuLogicSystems commented 7 years ago

Yes, I can confirm.