search

Obsidian-StudiosInc / entrance

General purpose Display Manager built on the Enlightenment Foundation Libraries (EFL)
GNU General Public License v3.0
23 stars 10 forks source link

Build Failure via meson_options #31

Closed SolarAquarion closed 5 years ago

SolarAquarion commented 5 years ago

meson_options.txt:9:0: ERROR: Option name debug is reserved.

wltjr commented 5 years ago

That seems new, what version of meson? I guess it does not dislike the usage in the main file. I guess I need to omit the debug option from that file. Part of mesons growing pains. They tend to make changes that are not legacy complaint, so breaks stuff. I assume your running a newer version I haven't built entrance under. Thus the error. Thanks for the report!

SolarAquarion commented 5 years ago

I got the error from the aur, they also were posting that problem to other forums

On Thu, Oct 25, 2018 at 1:21 PM William L Thomson Jr < notifications@github.com> wrote:

That seems new, what version of meson? I guess it does not dislike the usage in the main file. I guess I need to omit the debug option from that file. Part of mesons growing pains. They tend to make changes that are not legacy complaint, so breaks stuff. I assume your running a newer version I haven't built entrance under. Thus the error. Thanks for the report!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Obsidian-StudiosInc/entrance/issues/31#issuecomment-433135530, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iPUjzZEUWgvrboiMN0a19esfLTfYks5uofMTgaJpZM4X6gWL .

wltjr commented 5 years ago

I am tempted to replace meson with cmake. I do not like versions changing such that they break existing builds. Meson still seems to new... In Travis I am using 0.44, I just installed 0.48.1 replacing 0.47.1. I do not want to keep fixing or dealing with the build system. At least when I am not adding new features and nothing has changed.

wltjr commented 5 years ago

Looking back at the history, this is the 3rd time meson changes broke entrance build. I think I am done with meson. I am going to work on cmake build system and drop meson till the project matures. I do not want to have to worry about versions, installing newer python in travis and a whole slew of other stuff to use meson. Just not worth the time... Lost to much time on meson as is....

SolarAquarion commented 5 years ago

Modern cmake is a lot cleaner as far as I know.

On Thu, Oct 25, 2018, 7:01 PM William L Thomson Jr notifications@github.com wrote:

Looking back at the history, this is the 3rd time meson changes broke entrance build. I think I am done with meson. I am going to work on cmake build system and drop meson till the project matures. I do not want to have to worry about versions, installing newer python in travis and a whole slew of other stuff to use meson. Just not worth the time... Lost to much time on meson as is....

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Obsidian-StudiosInc/entrance/issues/31#issuecomment-433233424, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iLCcR0ZRiDsjGi4YsykB5ljlfAF4ks5uokK1gaJpZM4X6gWL .

wltjr commented 5 years ago

With cmake I do not have to worry about the version installed in Travis or Shippable, or even install anything. Unless I want to use ninja in Travis/Shippable with cmake. Which I do need to figure out someday. I can also create deb and rpm from cmake with cpack. Where presently releases only have sources and others have to create their own binaries.

I like meson, but that it may continue to break. That it has broken for entrance 3 times in a year. It seems like more of a waste of time. Any time saved in build is lost otherwise. This recent change with build option. I really feel could have and should have been handled in a friendlier way. Maybe some period of deprecation.

But that I will have to require everyone to use 0.48.1+. Where now people can use any version from 0.44 on up. I think it only required 0.40, per the version line in meson.build. Not sure its good for a project to require the latest version of a build system. It may not be present in many instances. Having to update a build system just to build a package is not really ideal for end users or the developer.

wltjr commented 5 years ago

A temporary solution is to just comment out those lines in meson_options.txt. I doubt most need to build it with debug enabled. That is mostly for development and CI stuff like code coverage etc.

wltjr commented 5 years ago

@SolarAquarion do you need a new tag for the AUR package? Or is this being pulled live from git?

SolarAquarion commented 5 years ago

Live from git

On Thu, Oct 25, 2018, 8:07 PM William L Thomson Jr notifications@github.com wrote:

@SolarAquarion https://github.com/SolarAquarion do you need a new tag for the AUR package? Or is this being pulled live from git?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Obsidian-StudiosInc/entrance/issues/31#issuecomment-433244963, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iEijBjFSd7B44K7aeS1B5PMYBRTeks5uolIlgaJpZM4X6gWL .

wltjr commented 5 years ago

Ok cool, if you need a new tag just let me know. I plan to do a new release. Though was hoping to resolve the #30 before next tag/release. But I can due to the issues with meson if needed. Getting no love from upstream as usual on #30. Pretty odd as it broke between beta and release. Not to many commits, just haven't been able to nail it down.