search

Obsidian-StudiosInc / entrance

General purpose Display Manager built on the Enlightenment Foundation Libraries (EFL)
GNU General Public License v3.0
23 stars 10 forks source link

Remember session issues #43

Open Thanatermesis opened 4 years ago

Thanatermesis commented 4 years ago

When a user logins succesfully in a desktop, seems like the selected choice is not correctly remember later, I assume it should be always remember in case that the process exits correctly?

The file /var/cache/entrance/entrance.hst seems like to be used for remember the user's sessions, after to decode the file with eet seems like it includes a history of all the actions, the question is, is this file meant to grow indefinitely ? (Or it should be limited to a number of entries?)

triantares commented 4 years ago

I can confirm this. I found that setting a user A to "autologin" and rebooting will allow settings to be remembered .... even if "autologin" is disabled again afterwards. Creating a new user B shows exactly the same behaviour (not remembering) and once used with "autologin" remembers it's last settings as well as that the old user A settings are also actively kept .

wltjr commented 4 years ago

Thanks for the report and confirmation! I will have to look into this. I recall it was saving it before. It should not require autologin to save a previous session selection.

Regarding the history file growing, it should not grow beyond one entry per user. The file should grow with using multiple different users. I have not looked into that, but should only be one entry per user. That is an area of entrance I have not spent much time working with. Because of such, it very likely could use some improvements and/or has some issues I have not run into.

Thanatermesis commented 4 years ago

Regarding the history file growing, it should not grow beyond one entry per user.

So it is not the case, the .hst file shows on me like 20-30 entries of the same user, some of them are set to a correct desktop selection and some are just empty (seems like the history is sometimes saved / called with uncomplete parameters?)

wltjr commented 4 years ago

Ok, thank you for that information. I do not have many desktops installed, which is likely why I have not run into this. But I also have not spent any time looking into the history code. Even if that was the original authors intention, I do not really see any benefit in that approach. You really just need one entry per user, the last one they used.

TheTechRobo commented 3 years ago

Remember session seems to work now.

wltjr commented 3 years ago

Interesting, I wonder if that was an EFL issue. Has the version of EFL been updated? I assume so, since nothing in Entrance has changed in a while to cause this to correct itself. Thanks for the update. We will have to see if it has corrected itself for the original reporter before considering this issue resolve, or otherwise. Thank you to all participating in this issue!