search

Obsidian-TTRPG-Community / Pathfinder-2E-SRD-Markdown

This is a place for Pathfinder Community Use content to be hosted in Markdown format for Obsidian.md
Other
60 stars 10 forks source link

Alchemical Gear and missing tags to appropriate items #10

Open alex-polosky opened 1 year ago

alex-polosky commented 1 year ago

Hello! First off, huge thank you to everyone involved with this project, it's quite an amazing feat.

I'm going through and making a few links to tables that I'll need for a quick reference in my campaign, and I noticed that in the alchemical-gear table (rules/tables/alchemical-gear) that 1) it doesn't link to the actual item, and 2) the items that are contained don't -technically- exist.

I am planning on fixing (1) wherever I find stated issue (I would link "Lesser acid flask" to acid-flask), and as far as (2) goes, I'm not sure how to resolve it.

In the chapter for the alchemical gear, it goes on after the table to explain each item in detail. The acid flask item detail only states that it does the "listed ... damage", which isn't much help either way. I'm thinking for items in this manner to have a few examples of "lesser", "greater", etc for quick damage references.

I'm planning on making these changes myself, but I also wanted to get some feedback on if anyone has any other ideas on how to go about fixing this, and if the community would be fine with me making a PR for it.

Thanks!

sigrunixia commented 1 year ago

Much of this data needs to be updated, and I will be pulling all the latest updates via pf2etools with the TTRPG-CLI tomorrow. Hold off on any PR's until then please.

Related: #11

sigrunixia commented 1 year ago

12 May have fixed this. It looks more fixed on my end, but we are still missing some processing items for GnG (Which Ebullient and I have been actively working on the past few weeks.)

Can you confirm?

alex-polosky commented 1 year ago

Definitely the trait tags have been fixed; however specifically for this issue there still aren't any links in (at least) the alchemical gear table and I'm still not sure what the best way to actually track what those items rules would be (lesser vs greater, etc.)

sigrunixia commented 1 year ago

I have a secondary update I am working on that may fix this as it finally imports all the missing guns and gears items.

However, I have also opened a ticket regarding tables because of some inconsistencies with the import cli. https://github.com/ebullient/ttrpg-convert-cli/issues/177

alex-polosky commented 1 year ago

These items aren't from guns and gears.

Lesser Acid Flask is a description of the generic item Acid Flask. Both are in the Core Rulebook; pg 292: ##Alchemical Bombs and pg 544 respectively.

I'm not entirely sure that the bug linked would be relevant here.

sigrunixia commented 1 year ago

Ah now I get you. Currently if items are variants, they are sometimes created as separate items, or not included. There is a PR https://github.com/ebullient/ttrpg-convert-cli/pull/176 that would add variants to existing items. I'll update here when this is accepted and the repo has been updated to include it.

As for the bug I linked, also because some items that are supposed to be there are not being generated as pages. ^_^;;;;;

alex-polosky commented 1 year ago

Ah alright well that makes sense! Thank you!