search

ObsidianBox / Obsidian

Obsidian is the implementation of Magma that extends Forge to deliver server-side content on demand.
http://obsidianbox.org
MIT License
12 stars 3 forks source link

Establishing if we need Custom*** Materials or not #8

Closed Zidane closed 10 years ago

Zidane commented 10 years ago

In Bukkit, no one checks Block instances to see if they are BlockSlab or BlockDoor...you check if their Material is Material.SLAB or Material.DOOR (as an example).

To create a Block, you typically need a Material instance. Some things are different: BlockFallingBlock (not exact name) sets the material for you. When first devising how to appropriately do addon-based Blocks I felt that we needed to provide custom material instances but now it seems almost pointless

Either the system needs to stay or goes. Discuss.

Lunaphied commented 10 years ago

I don't see an issue with the current system, works well enough. Most mod makers just want to create custom blocks such as machines, ores and decorations, fluids such as used by mechanical mod's for fuels and items such as tools and weapons. All of which are possible with the current system. Oh and don't forget custom entities and tile entities which aren't part of addons yet.

Grinch commented 10 years ago

Honestly I think we should just let them pass in a Material in the constructor. Right now you're also restricted to the map color of clay with our system.

Zidane commented 10 years ago

I have resolved this in https://github.com/ObsidianBox/Magma/commit/76edf953595cca80b3efa2cda80786fdf7815e84