search

ObsidianMC / Obsidian

A C# implementation of the Minecraft server protocol.
GNU General Public License v3.0
413 stars 42 forks source link

Better Configuration #437

Closed Tides closed 5 months ago

Tides commented 6 months ago

Replaces the old IServerConfiguration and uses the ConfigurationManager provided by Generic Host. This also makes it possible to now use environment variables to configure the server. As long as you're familiar with how people do it in asp net Core, the same would apply here. Another PR to generally improve and make this feel more .net like 🙏🏼 closes #407

Tides commented 6 months ago

Aside from half of the changes you've done not matching the title of the pull request, this look fine.

Lets just say they were all "necessary" changes and not me going on a minor side quest 😭 😭

Naamloos commented 6 months ago

looks good. Just curious about the logic of the pregenerated config files being there.

other than that, this closes #407 when merged.