search

Occulus-Server / Occulus-Eris

Occulus is a downstream from Eris, though we also have a fair bit of original content thanks to a decent sized development team.
Other
6 stars 48 forks source link

Cleans up Circuit disk addition + Re-allows crafting station printing #999

Closed Zenitheevee closed 1 year ago

Zenitheevee commented 1 year ago

About The Pull Request

Replaces a hard over-write with an initialization addition to the list

Why It's Good For The Game

hard overwrites bad, re-enables obtainment for crafting station

Changelog

fix: Replaces the circuit disk overwrites with a better addition
Jamini commented 1 year ago

Why are we doing it like this?

We use hard-overwrites to avoid a lot of issues with init setup and potential runtimes.

Zenitheevee commented 1 year ago

Why are we doing it like this?

We use hard-overwrites to avoid a lot of issues with init setup and potential runtimes.

Just parroting how we used the method for adding like we did on the rubber disk, even before the recent relocation and addition

And this system is more friendly for porting changes. If its a big problem i can just go back to a hard overwrite.

Jamini commented 1 year ago

Our modular files overwriting is very intentional however. Quite a lot of upstream "Changes" are intentionally reverted or blocked with modular overwrites.

I'd prefer we kept it as it was if that's alright.