search

Occupation-Ontology / OccO

OccO: Occupation Ontology
4 stars 13 forks source link

move occupation US SOC ID in a separate module #23

Closed zhengj2007 closed 7 months ago

johnbeve commented 7 months ago

@smithGit @yongqunh @zhengj2007 Why are separate modules being created? We did not discuss this.

smithGit commented 7 months ago

I have taken no recent (3+ months) action on the OccO info, so I am hoping either Jie or Oliver can address this. Sam

From: John Beverley @.> Sent: Saturday, December 9, 2023 3:05 AM To: Occupation-Ontology/OccO @.> Cc: Sam Smith @.>; Mention @.> Subject: Re: [Occupation-Ontology/OccO] move occupation US SOC ID in a separate module (PR #23)

@smithGit https://github.com/smithGit @yongqunh https://github.com/yongqunh @zhengj2007 https://github.com/zhengj2007 Why are separate modules being created? We did not discuss this.

— Reply to this email directly, view it on GitHub https://github.com/Occupation-Ontology/OccO/pull/23#issuecomment-1848318333 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2PKED2HOQFJZNHYOCFWLYIQLQ7AVCNFSM6AAAAABANQK2HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYGMYTQMZTGM . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABQ2PKDDZDULRSPL52G2ZVLYIQLQ7A5CNFSM6AAAAABANQK2HCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTOFMMX2.gif Message ID: @.***>

zhengj2007 commented 7 months ago

@smithGit @yongqunh @zhengj2007 Why are separate modules being created? We did not discuss this.

@johnbeve The modules created based on the design patterns. It allows us to create the terms using templates in tab-delimited format files and convert to the OWL format using Robot template command. See the wiki pages. So, we don't need to add/edit the term manually using Protege. Besides, it is easy to maintain the ontology and keep the terms implemented consistently. We can discuss the design patterns and adjust the templates if needed.

I put the US SOC ID in a separate module because the IDs only applied to occupation terms not all OCCO terms. It's easy for us to see the mapping in one file. Besides, the template is using tsv file, some US SOC IDs automatically convert to date format (such as 11-2000 -> Nov-00 for OCCO_11200000) when open automatically in Excel. US SOC IDs are quit stable information, we don't need change frequently comparing to term definitions (in occo_terms.tsv). Put US SOC IDs in a separate module can avoid the US SOC IDs changing unintended.

johnbeve commented 7 months ago

@zhengj2007 I understand templates and design patterns. It seems to me that you've unilaterally made changes to the main branch of a collaborative project without collaborating with other members of the group.

Either (1) you should've created a PR for review before merging or (2) we should've agreed as a group to these updates before they were implemented.

zhengj2007 commented 7 months ago

@johnbeve I created the pull requests for all the changes I made. I merge the changes for including the Alabama terms and creating the views for the coming Alabama meeting. If you prefer, I can redo the merge and assign you to review all the changes I made. Please let me know if you'd like me to redo the merge. In the future, I won't merge the pull requests before reviewing.