Closed jagoosw closed 1 year ago
Let’s see the preview before approving
Yeah, seems to work locally but lets see
Patch coverage has no change and project coverage change: -0.21
:warning:
Comparison is base (
888a107
) 52.78% compared to head (461724c
) 52.58%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Not sure whats caused this docs error, other people seem to have been getting the same recently: https://github.com/trixi-framework/Trixi.jl/issues/1475
I can dig in. I think I was getting this yesterday snd fixed it. It because eg there are two doc sections with name LOBSTER so [LOBSTER](@ref)
becomes ambiguous
Ah I see, I though they had to be names like (@id LOBSTER)
to be referenced. I imagine this is coming from the page titles and the new parameter pages so I will try changing the automatic title to X default parameters
rather than just X
.
This is one way to reference them. But also module or methods names. And eg because the LOBSTER constructor is in the docs library then if you make another page with @id LOBSTER you run into trouble. 🦞
Ah I see, thank you
This is one way to reference them. But also module or methods names. And eg because the LOBSTER constructor is in the docs library then if you make another page with @id LOBSTER you run into trouble. 🦞
(i think that’s the culprit)
lgtm
it'd be nice if units appeared... but it's definitely good for now!
Yeah that would be good, I'm not sure how, maybe with something like Unitful.
This adds the automatic generation of pages showing the default parameter values for models. I think this is quite important because I've often struggled trying to find parameter values for BGC models because often a couple are missed in papers, but with this we know the defaults in some version and can just detail variations from default.
Fixes #98