search

OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
48 stars 21 forks source link

Optimize #105

Closed navidcy closed 1 year ago

navidcy commented 1 year ago

This is not a thorough optimization but I've added some missing @inbounds.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.34 :warning:

Comparison is base (feddb7b) 52.58% compared to head (ec59091) 52.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================== - Coverage 52.58% 52.24% -0.34% ========================================== Files 26 26 Lines 1027 1026 -1 ========================================== - Hits 540 536 -4 - Misses 487 490 +3 ``` | [Impacted Files](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME) | Coverage Δ | | |---|---|---| | [src/Boundaries/Sediments/coupled\_timesteppers.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0JvdW5kYXJpZXMvU2VkaW1lbnRzL2NvdXBsZWRfdGltZXN0ZXBwZXJzLmps) | `84.61% <0.00%> (-11.22%)` | :arrow_down: | | [src/Light/morel.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0xpZ2h0L21vcmVsLmps) | `0.00% <0.00%> (ø)` | | | [src/Models/Models.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL01vZGVscy9Nb2RlbHMuamw=) | `0.00% <ø> (ø)` | | | [src/Particles/tracer\_tendencies.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL1BhcnRpY2xlcy90cmFjZXJfdGVuZGVuY2llcy5qbA==) | `9.09% <0.00%> (ø)` | | | [src/Utils/negative\_tracers.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL1V0aWxzL25lZ2F0aXZlX3RyYWNlcnMuamw=) | `0.00% <0.00%> (ø)` | | | [src/Utils/timestep.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL1V0aWxzL3RpbWVzdGVwLmps) | `0.00% <0.00%> (ø)` | | | [src/Boundaries/gasexchange.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0JvdW5kYXJpZXMvZ2FzZXhjaGFuZ2Uuamw=) | `84.48% <66.66%> (+1.43%)` | :arrow_up: | | [src/Boundaries/Sediments/simple\_multi\_G.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0JvdW5kYXJpZXMvU2VkaW1lbnRzL3NpbXBsZV9tdWx0aV9HLmps) | `85.36% <100.00%> (+3.54%)` | :arrow_up: | | [src/Light/2band.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0xpZ2h0LzJiYW5kLmps) | `86.48% <100.00%> (-0.36%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.