OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Fixing a typo #117

Closed jagoosw closed 1 year ago

jagoosw commented 1 year ago

closes #116

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 54.54% and no project coverage change.

Comparison is base (1997775) 61.46% compared to head (4a26202) 61.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #117 +/- ## ======================================= Coverage 61.46% 61.46% ======================================= Files 26 26 Lines 968 968 ======================================= Hits 595 595 Misses 373 373 ``` | [Impacted Files](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME) | Coverage Δ | | |---|---|---| | [src/Light/Light.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0xpZ2h0L0xpZ2h0Lmps) | `0.00% <ø> (ø)` | | | [src/Models/AdvectedPopulations/LOBSTER/LOBSTER.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL01vZGVscy9BZHZlY3RlZFBvcHVsYXRpb25zL0xPQlNURVIvTE9CU1RFUi5qbA==) | `81.25% <0.00%> (ø)` | | | [src/Models/AdvectedPopulations/NPZD.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL01vZGVscy9BZHZlY3RlZFBvcHVsYXRpb25zL05QWkQuamw=) | `90.27% <ø> (ø)` | | | [src/OceanBioME.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL09jZWFuQmlvTUUuamw=) | `0.00% <ø> (ø)` | | | [src/Light/2band.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0xpZ2h0LzJiYW5kLmps) | `86.11% <60.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

navidcy commented 1 year ago

If you add to the first comment of this PR "closes #116" (no quotation marks) then when the PR merges the issue will close as well.

navidcy commented 1 year ago

@jagoosw can you give me full organization rights (I can't see the organization settings) -- I'll try to figure out the TagBot situation.

johnryantaylor commented 1 year ago

Thanks Navid, I sent an invitation to the organization with Manage rights.  Will that let you do this? On Jun 26, 2023 at 10:14 PM +0100, Navid C. Constantinou @.***>, wrote:

@jagoosw can you give me full organization rights (I can't see the organization settings) -- I'll try to figure out the TagBot situation. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

navidcy commented 1 year ago

Thanks Navid, I sent an invitation to the organization with Manage rights.  Will that let you do this?

I still don't see organization rights. :(

johnryantaylor commented 1 year ago

Ok, I gave you owner-level permission - can you try again? (strange that the Manage role isn’t sufficient) On Jun 26, 2023 at 11:33 PM +0100, Navid C. Constantinou @.***>, wrote:

Thanks Navid, I sent an invitation to the organization with Manage rights.  Will that let you do this? I still don't see organization rights. :( — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>