Closed jagoosw closed 1 year ago
Think this is probably the most straightforward way to set this up, and in this case the bottom cell only has to be calculated once
I think in the same vein it may be worth modifying PAR integration to only integrate down to the bottom cell since a lot of the globe doesn't reach the bottom of the underlying grid (and at the moment I think we integrate it for the land area too)
Patch coverage: 76.00%
and project coverage change: -0.24%
:warning:
Comparison is base (
ef69e24
) 63.82% compared to head (3a352ad
) 63.58%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Since it's just the codecov failing (and I'm not bothered by the lines in the NPZD model it says aren't being tested as it's just a warning and function no one will probably ever use) I'm happy for this PR to be merged now
The example was failing because I'd changed the sediment models to only use flat fields, but we can't output these still due to https://github.com/CliMA/Oceananigans.jl/issues/2770 which I've not fixed yet
Nonhydrostatic + RK3 is not getting tested but it should
This PR makes sediment models work with immersed boundary grids and improves sediment testing on all grid and model types.
This breaks the sediment, nitrogen/carbon flux, and sinking flux APIs.