OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Added model implementaion page #131

Closed jagoosw closed 1 year ago

jagoosw commented 1 year ago

Closes #129

jagoosw commented 1 year ago

lets see if it runs

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (7d43ed6) 63.82% compared to head (92d1914) 63.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ======================================= Coverage 63.82% 63.82% ======================================= Files 28 28 Lines 1020 1020 ======================================= Hits 651 651 Misses 369 369 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jagoosw commented 1 year ago

132 broke the image display (https://oceanbiome.github.io/OceanBioME.jl/previews/PR131/model_components/biogeochemical/NPZ/) so trying another method.

I thought I had checked the preview but its broken now.

jagoosw commented 1 year ago

@iuryt, if you're happy with this please could you approve the PR so I can merge when the tests have run?

jagoosw commented 1 year ago

All fixed, ready to merge

navidcy commented 1 year ago

Nice!