OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
48 stars 21 forks source link

Update eady.jl #136

Closed johnryantaylor closed 1 year ago

johnryantaylor commented 1 year ago

reduced initial timestep to 1 minute in Eady.jl to be more conservative and avoid CFL violation on finer grids

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (21fb27c) 63.82% compared to head (1f87d4d) 63.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ======================================= Coverage 63.82% 63.82% ======================================= Files 28 28 Lines 1020 1020 ======================================= Hits 651 651 Misses 369 369 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jagoosw commented 1 year ago

Could we do:

vâ‚€ = V(0, 0, 0, 0, background_state_parameters)

Δx = minimum_xspacing(grid, Center(), Center(), Center())
Δy = minimum_yspacing(grid, Center(), Center(), Center())
Δz = minimum_zspacing(grid, Center(), Center(), Center())

Δt₀ = 0.75 * min(Δx, Δy, Δz) / v₀

simulation = Simulation(model, Δt = Δt₀, stop_time = 10days)

so that it is setup right whatever grid size someone uses?

johnryantaylor commented 1 year ago

Good idea - this might work On Aug 29, 2023 at 10:32 AM +0100, Jago Strong-Wright @.***>, wrote:

Could we do: vâ‚€ = V(0, 0, 0, 0, background_state_parameters)

Δx = minimum_xspacing(grid, Center(), Center(), Center()) Δy = minimum_yspacing(grid, Center(), Center(), Center()) Δz = minimum_zspacing(grid, Center(), Center(), Center())

Δt₀ = 0.75 * min(Δx, Δy, Δz) / v₀

simulation = Simulation(model, Δt = Δt₀, stop_time = 10days) so that it is setup right whatever grid size someone uses? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>