OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
48 stars 21 forks source link

(0.8.0) Drop support for prescribing T and S in kelp and gas exchange models #149

Closed jagoosw closed 1 year ago

jagoosw commented 1 year ago

I've been meaning to drop support for prescribing temperature and salinity in the gas exchange and kelp models as it made a mess of the code and is a hangover from some of our column experiments which isn't needed since they can just be put in the model as a function field much more cleanly.

I have also removed the mess that was how gas exchange model functions were setup since I found out you can subtype Function and it solved the prior issues.

I have also changed the eady example to have a T and S dependant buoyancy model as it is now essential for kelp models (and makes sense anyway).

This breaks the API for GasExchange and SLatissima.

Depends on Oceananigans PR #3323

jagoosw commented 1 year ago

TODO: Remove erroneous changes to Project.toml

navidcy commented 1 year ago

Since https://github.com/CliMA/Oceananigans.jl/pull/3323 was merged, I added a compat for Oceananigans v0.89.2.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cdb79a3) 65.69% compared to head (49e5e99) 65.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== + Coverage 65.69% 65.84% +0.14% ========================================== Files 27 27 Lines 1064 1054 -10 ========================================== - Hits 699 694 -5 + Misses 365 360 -5 ``` | [Files](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME) | Coverage Δ | | |---|---|---| | [src/Boundaries/gasexchange.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL0JvdW5kYXJpZXMvZ2FzZXhjaGFuZ2Uuamw=) | `89.58% <100.00%> (+4.12%)` | :arrow_up: | | [src/Models/Individuals/SLatissima.jl](https://app.codecov.io/gh/OceanBioME/OceanBioME.jl/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanBioME#diff-c3JjL01vZGVscy9JbmRpdmlkdWFscy9TTGF0aXNzaW1hLmps) | `84.86% <85.71%> (+0.99%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jagoosw commented 1 year ago

everything seems to work again now

jagoosw commented 1 year ago

lgtm

just a few suggestions!

Thank you!