Closed jagoosw closed 1 year ago
TODO: Remove erroneous changes to Project.toml
Since https://github.com/CliMA/Oceananigans.jl/pull/3323 was merged, I added a compat for Oceananigans v0.89.2.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
cdb79a3
) 65.69% compared to head (49e5e99
) 65.84%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
everything seems to work again now
lgtm
just a few suggestions!
Thank you!
I've been meaning to drop support for prescribing temperature and salinity in the gas exchange and kelp models as it made a mess of the code and is a hangover from some of our column experiments which isn't needed since they can just be put in the model as a function field much more cleanly.
I have also removed the mess that was how gas exchange model functions were setup since I found out you can subtype Function and it solved the prior issues.
I have also changed the eady example to have a T and S dependant buoyancy model as it is now essential for kelp models (and makes sense anyway).
This breaks the API for
GasExchange
andSLatissima
.Depends on Oceananigans PR #3323