search

OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Use Julia v1.10 + CairoMakie v0.11 #166

Closed navidcy closed 6 months ago

navidcy commented 7 months ago

use Julia v1.10 for CI and docs

also uses CairoMakie v0.11 and updates Figure(resolution=...) to Figure(size=...).

navidcy commented 7 months ago

Actually we should better wait for https://github.com/CliMA/Oceananigans.jl/pull/3403

jagoosw commented 7 months ago

Should we attempt to get rid of all of the @unrolls that are giving warnings

navidcy commented 7 months ago

I removed a few. The rest are in Oceananigans and https://github.com/CliMA/Oceananigans.jl/pull/3403 should clear them up.

navidcy commented 6 months ago

I think we are ready for this PR since https://github.com/CliMA/Oceananigans.jl/pull/3403 was merged.

jagoosw commented 6 months ago

Sorry for the slow response to this. Does the current version of Oceananigans have some warnings left like in the tests or are they coming from OceanBioME?

navidcy commented 6 months ago

We need to retrigger the tests so they use v0.90.9

jagoosw commented 6 months ago

I restarted them now

navidcy commented 6 months ago

I don't understand why the CI has trouble installing Oceananigans v0.90.10

Also, what triggers this warning?

https://buildkite.com/oceanbiome/oceanbiome/builds/134#018e2e08-1b82-42e2-8aa9-5a627152001d/25-28

navidcy commented 6 months ago

OK, now some actual tests are failing.

https://buildkite.com/oceanbiome/oceanbiome/builds/139#018e2e20-3791-4893-aa3a-a5772bc0c7ed/19-383

Any idea @jagoosw?

jagoosw commented 6 months ago

I see you've resolved it now but I am also having trouble compiling 0.90.10 locally, when I update my julia to 1.10 it is resolved but might be something I should mention on the other repo.

I'll try and work out whats going on with that test now.

navidcy commented 6 months ago

I think this is ready to go. I updated to Oceananigansv v0.90.11 that removed some of the unroll-related warnings that had sneaked in by accident. @jagoosw?

jagoosw commented 6 months ago

Great, thank you for sorting this!