search

OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Update gas transfer coefficients #168

Open vtamsitt opened 6 months ago

vtamsitt commented 6 months ago

I'm interested in implementing updated gas transfer velocity (k) parameterisations (at the very least, Wanninkhof 1992 is outdated and could be replaced by Wanninkhof 2014). It would be great to add other gas transfer velocities e.g. Ho et al. 2006, as is mentioned in the code comments. I'm guessing the best way to implement this would be to add all of these parameterisations (and more?) and include a kwarg when calling GasExchange? https://github.com/OceanBioME/OceanBioME.jl/blob/0b45a16ee2017af6ac3d8cebbbb613760983d6ae/src/Boundaries/gasexchange.jl#L127

johnryantaylor commented 6 months ago

Hi @vtamsitt, thanks! That would be great and what you suggest seems like a good approach

vtamsitt commented 6 months ago

Great, I'll work on this when I get a chance.

glwagner commented 6 months ago

It could make sense to add a property called transfer_velocity here:

https://github.com/OceanBioME/OceanBioME.jl/blob/0b45a16ee2017af6ac3d8cebbbb613760983d6ae/src/Boundaries/gasexchange.jl#L142

then it'll be easy to add new models (for developers) or to switch between models (for users)