search

OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Added `invalid_fill_value` to `ScaleNegativeTracers` #170

Closed jagoosw closed 5 months ago

jagoosw commented 5 months ago

This PR adds a parameter invalid_fill_value to ScaleNegativeTracers so that when the total cell content is less than 0 it doesn't have to be filled with NaNs. While even less ideal this seems to be the easiest way to keep complex models positive (e.g. the near global model), and is akin to how lots of earth system models do it.

jagoosw commented 5 months ago

Thanks for sorting @navidcy, I'm going to bump the patch number and they merge