search

OceanBioME / OceanBioME.jl

🌊 🦠 🌿 A fast and flexible modelling environment written in Julia for modelling the coupled interactions between ocean biogeochemistry, carbonate chemistry, and physics
https://oceanbiome.github.io/OceanBioME.jl/
MIT License
40 stars 20 forks source link

Makes testing more robust #189

Closed jagoosw closed 1 month ago

jagoosw commented 1 month ago

There is a race condition in the testing pipeline where if you start a job while another is running, the first might delete the julia instance before the second one completes.

This PR should prevent that condition from occuring.

jagoosw commented 1 month ago

This seems to have worked here, I re-ran this + another of the open PRs tests at the same time and it didn't cause any issues like it normally would

jagoosw commented 1 month ago

And it segfaulted

jagoosw commented 1 month ago

As concluded in the Oceananigans PR I made this doesn't seem to work