added ability to add headers to text_files, log_files & text-based files

[webbpinner]

Code changes and update unit tests need to implement #314

[webbpinner]

Correct, ...and I was also torn between the current implementation vs having 2 header args. In the end I would just like the ability to add files headers from a string or filepath. I'm less concerned whether it's one or two args. What makes the most sense to you and is most inline which the rest of the project?

[davidpablocohn]

I think I prefer the route of having two different parameters, following the logic that they'd be less prone to misinterpretation. Thanks!

On Mon, Jul 18, 2022 at 2:40 AM Webb Pinner @.***> wrote:

Correct, ...and I was also torn between the current implementation vs having 2 header args. In the end I would just like the ability to add files headers from a string or filepath. I'm less concerned whether it's one or two args. What makes the most sense to you and is most inline which the rest of the project?

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/315#issuecomment-1186985077, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3RY5GJN6HIZYIWGVHDVUURBHANCNFSM53ZU7QTA . You are receiving this because you commented.Message ID: @.***>

[webbpinner]

Ok, changes made. Please take a look when you have time.

[davidpablocohn]

Looks good - thank you!