search

OceanDataTools / openrvdas

An open source data acquisition system designed for use on research vessels and other scientific installations
http://openrvdas.org
Other
39 stars 20 forks source link

Remove redundant UDP code from NetworkWriter, finish/fix broken TCP code, and rename to TCPWriter #347

Closed veggiemike closed 9 months ago

veggiemike commented 10 months ago

Title says it all. I haven't done this yet, so figured I'd make it an "issue" to discuss. There's a ton of redundant functionality in NetworkWriter that I just finished cleaning up and thoroughly testing in UDPWriter. Are you opposed to me removing all the UDP code from NetworkWriter? Then all that's left is non-functional TCP code, which will be a lot easier to finish and maintain with the UDP removed. Of course then the name is silly, so perhaps we rename it TCPWriter?

I'm itching to do it.

davidpablocohn commented 10 months ago

I think that makes sense. I don't think anyone is using NetworkWriter. But rather than just disappearing it, I think the gentler transition ("Your mission, should you choose to accept it...") would be to replace the old NetworkWriter with a shell that says "This class is deprecated - please use TCPWriter or UDPWriter instead"

If you're up for that, I'd be very grateful.

I've accumulated a bunch of other small changes*, too, so once this is done, I think it makes sense to push out another versioned "master".

*The one I'm most excited about is supporting "--database sqlite" in the logger manager, so the entire thing can be run Django-free. Kevin Pedigo has a pure js/sqlite-based GUI that's still a little rudimentary but looks like an excellent template for creating a simpler way to drive the system.

veggiemike commented 10 months ago

That sounds perfect to me! I'll let you know if I run into any roadblocks!

davidpablocohn commented 9 months ago

Merged to dev, master