Replace NetworkWriter with TCPWriter

[veggiemike]

Pablo, this branch should do exactly what we discussed for Issue #347. The first couple commits are almost identical to changes made to UDPWriter last week, then it removes UDP from NetworkWriter, gets TCP working, renames it to TCPWriter, and leaves behind a noisy NetworkWriter class that just tells users to use UDPWriter or TCPWriter. I've also added --write_tcp to listen.py and fixed encoding usage in there so it can use UDPWriter and TCPWriter with raw/binary data (should have done that previously, but didn't realize it existed). Thanks!

[davidpablocohn]

Oh - maybe on the "help" we could have a note saying "DEPRECATED in favor of --udp and --tcp"?

On Wed, Oct 25, 2023 at 12:16 PM Michael D Labriola < @.***> wrote:

@.**** commented on this pull request.

In logger/listener/listen.py https://github.com/OceanDataTools/openrvdas/pull/348#discussion_r1372220682 :

@@ -483,9 +486,13 @@ def init(self, config_file, config_name=None, log_level=None): parser.add_argument('--write_network', dest='write_network', default=None,

You got it!

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/348#discussion_r1372220682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3QENTUCLGGPO2GYL7LYBFQPFAVCNFSM6AAAAAA6NAEE3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJYGA4DQNJZGA . You are receiving this because you commented.Message ID: @.***>

[veggiemike]

Actually, we've more than deprecated it... it's gone. But I'll stick something in the help message to say it's been REPLACED by --write_udp and --write_tcp. So you get a notice in --help output, and if you try and run it, you get error messages that it's been replaced by UDPWriter and TCPWriter. Should not go unnoticed, for sure. Heh.

[davidpablocohn]

Ah you're right! "Deprecated with Extreme Prejudice," then. :-)

On Wed, Oct 25, 2023, 9:28 AM Michael D Labriola @.***> wrote:

Actually, we've more than deprecated it... it's gone. But I'll stick something in the help message to say it's been REPLACED by --write_udp and --write_tcp. So you get a notice in --help output, and if you try and run it, you get error messages that it's been replaced by UDPWriter and TCPWriter. Should not go unnoticed, for sure. Heh.

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/348#issuecomment-1779918793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3QRFRLRKME5ZMZT2SDYBFR4JAVCNFSM6AAAAAA6NAEE3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZHEYTQNZZGM . You are receiving this because you commented.Message ID: @.***>

[veggiemike]

I think I've resolved all your comments, Pablo!

[davidpablocohn]

Many thanks!