search

OceanDataTools / openrvdas

An open source data acquisition system designed for use on research vessels and other scientific installations
http://openrvdas.org
Other
39 stars 20 forks source link

Remove deprecated `interface` from UDPWriter and a couple misc fixes #351

Closed veggiemike closed 10 months ago

veggiemike commented 10 months ago

Pablo, are you OK with removing the interface parameter from UDPWriter? It got flagged as deprecated back in 2020, described as PARTIALLY BROKEN, and it's making life difficult while I'm adding new things.

This commit has a couple other tweaks, but they're all misc cleanup commits.

davidpablocohn commented 10 months ago

More than happy for it to go away - thank you!

On Thu, Oct 26, 2023, 1:51 PM Michael D Labriola @.***> wrote:

Pablo, are you OK with removing the interface parameter from UDPWriter? It got flagged as deprecated back in 2020, described as PARTIALLY BROKEN, and it's making life difficult while I'm adding new things.

This commit has a couple other tweaks, but they're all misc cleanup commits.

You can view, comment on, or merge this pull request online at:

https://github.com/OceanDataTools/openrvdas/pull/351 Commit Summary

File Changes

(2 files https://github.com/OceanDataTools/openrvdas/pull/351/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3UZ3SBLQSVMWLPSTCTYBLZRRAVCNFSM6AAAAAA6R7PQX2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DINJTGUYDQMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

veggiemike commented 10 months ago

Were you going to merge this? I've got another pull request queued up to send over, but I wanted to rebase it off of your dev branch after this is merged to avoid conflicts.

davidpablocohn commented 10 months ago

Oops - done! I've been on the road

On Sat, Oct 28, 2023, 12:24 PM Michael D Labriola @.***> wrote:

Were you going to merge this? I've got another pull request queued up to send over, but I wanted to rebase it off of your dev branch after this is merged to avoid conflicts.

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/351#issuecomment-1783903109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3VX5SRFMNPEKLLIUETYBVLXZAVCNFSM6AAAAAA6R7PQX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHEYDGMJQHE . You are receiving this because you commented.Message ID: @.***>

veggiemike commented 10 months ago

No problem! I just realized it's Saturday, too. Can't really tell out here.