search

OceanDataTools / openrvdas

An open source data acquisition system designed for use on research vessels and other scientific installations
http://openrvdas.org
Other
39 stars 20 forks source link

listen.py: make --encoding apply to all readers/writers/transforms #358

Closed veggiemike closed 10 months ago

veggiemike commented 10 months ago

As noted in issue #353 (which was otherwise just user-error on my part), --encoding needs to be specified at-most once and can't change between parsing segments. If you change encoding between them, you'll just make Python spit out TypeError: a bytes-like object is required, not 'str' on the very first input read().

This commit makes --encoding apply to all readers/writers/transforms, regardless of it's location in the argument string, and adds words to the --help message noting this behavior.

davidpablocohn commented 10 months ago

Thanks for this!

I'm getting ready to merge the latest dev into a new numbered master version. Are there other changes you have in the pipeline? If so, I'll hold off until they're ready.

veggiemike commented 10 months ago

My pipeline is officially empty (for now). Thanks!

On Thu, Nov 2, 2023, 04:14 David Pablo Cohn @.***> wrote:

Thanks for this!

I'm getting ready to merge the latest dev into a new numbered master version. Are there other changes you have in the pipeline? If so, I'll hold off until they're ready.

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/358#issuecomment-1790817740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AROPDNEGMJAO5A2IMRMRGG3YCOTDLAVCNFSM6AAAAAA6YNYBS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHAYTONZUGA . You are receiving this because you authored the thread.Message ID: @.***>

davidpablocohn commented 10 months ago

Whew - thanks for everything you patched/fixed/enhanced!

On Thu, Nov 2, 2023 at 12:23 PM Michael D Labriola @.***> wrote:

My pipeline is officially empty (for now). Thanks!

On Thu, Nov 2, 2023, 04:14 David Pablo Cohn @.***> wrote:

Thanks for this!

I'm getting ready to merge the latest dev into a new numbered master version. Are there other changes you have in the pipeline? If so, I'll hold off until they're ready.

— Reply to this email directly, view it on GitHub < https://github.com/OceanDataTools/openrvdas/pull/358#issuecomment-1790817740>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AROPDNEGMJAO5A2IMRMRGG3YCOTDLAVCNFSM6AAAAAA6YNYBS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHAYTONZUGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/358#issuecomment-1791417132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3VQVIVAFGLWZWHO3ADYCPXLXAVCNFSM6AAAAAA6YNYBS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGQYTOMJTGI . You are receiving this because you modified the open/close state.Message ID: @.***>