search

OceanDataTools / openrvdas

An open source data acquisition system designed for use on research vessels and other scientific installations
http://openrvdas.org
Other
39 stars 20 forks source link

Fix all those broken unittests, and maybe move all to "test" subdir #371

Closed davidpablocohn closed 4 months ago

davidpablocohn commented 5 months ago

Code rot. Many unittests now throw errors or deprecation warnings. Need to fix them.

Also consider moving all logger unittests from their reader/transform/writer/utils directories to a separate test/ subdir, as CSIRO has done.

davidpablocohn commented 4 months ago

All unittest failures, with the exception of test_serial_writer.py, have been fixed. The test_serial_writer.py code, and possibly SerialWriter itself, needs work.

Deprecation warnings for CachedDataServer remain for Python v3.10 and above. They can be suppressed with the -W flag, as:

  python -W ignore::DeprecationWarning -m unittest discover
davidpablocohn commented 4 months ago

Still need to decide whether to move all unittests into a separate test/ subdir.