OceanGlidersCommunity / OG-format-user-manual

OceanGliders format and vocabularies
15 stars 13 forks source link

RTQC methods global attribute #78

Open vturpin opened 2 years ago

vturpin commented 2 years ago

"RTQC methods" and "RTQC methods doi" are currently mandatory in the global attribute and in the variable attribute. I suggest we remove it from the global attribute and leave it mandatory in the variable attribute.

castelao commented 2 years ago

Two parts:

vturpin commented 2 years ago

Ok for both locations if this is a recommendation from Cf. But we need to explain that on the document. Let's put it as highly desirable for RTQC method and doi. QC is part of the role of the Data assembly centers as well as converting raw into OG1.0. DAC should have the ressources for RTQC. Isn't there a risk to finally have non QC data sets ?

castelao commented 2 years ago

Yes, there is a risk of having non-QCed data, but in my opinion, that is worse than having no data at all. Once a dataset gets into the system, somebody else (not ideal but) could apply the QC. From the user's perspective, the lack of QC method and flags tells enough how much that data should be trusted.

I do think QCing is important and should be a priority, but I'm afraid of making a harder entry point for new glider operators. I think highly desirable would be appropriate, no less than that. Any group with the required resources would certainly put effort into the high-priority components.

Could you open a PR with such changes on the document, please?

vturpin commented 2 years ago

Can we put a level of requierment to a variable attribute?

justinbuck commented 1 year ago

OG 1.0 meeting notes: Global level RTQC is useful but would need to be a list of methods applied within the data Variable level is needed by DACs. Tool (software, in history attribute for ACDD), thresholds applied (history attribute for ACDD), and procedure (e.g. QUARTOD DOI) both need to be documented. Needs to be downgraded to highly desirable in PG 1.0 (Gui working on pull request). Needs more time and discussion and scoping in OG 1.1.