search

OceanGlidersCommunity / Salinity_SOP

Salinity Standard Operating Procedure (SOP)
https://oceangliderscommunity.github.io/Salinity_SOP/README.html
Other
6 stars 7 forks source link

Testing embedded video #116

Closed jbusecke closed 1 year ago

jbusecke commented 2 years ago

Possible solution to #34.

github-actions[bot] commented 2 years ago

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: f1f4ce1ff9ca679595582e92f058cac8c4456368 ✅ Deployment Preview URL: https://61aa3e3a9add4462ebf5f359--salinitysop.netlify.app

soerenthomsen commented 2 years ago

Checked the preview deployment and looks great. it is also possible to put the video file into the GitHub repo and embed it directly? Or does it have to be uploaded to a video platform like Vimeo or YouTube before?

jbusecke commented 2 years ago

I think it only works with streaming services. Adding videos to the gh repo seems like a bad idea, since they will usually be very big.

soerenthomsen commented 2 years ago

And is it possible to upload a gif to the repo? This might be enough for our case?

jbusecke commented 2 years ago

That should work just as is! Just watch the size.

jbusecke commented 2 years ago

Is this still a desired feature? Or can we close this?

soerenthomsen commented 2 years ago

I vote for closing it for now. @isgiddy ? Might just create problems with releasing v1.0.0 as pdf etc

jbusecke commented 1 year ago

I am closing this. Please reopen if you see necessary.