search

OceanLabs / FacebookImagePicker-iOS

A Facebook image picker providing a simple UI for a user to pick photos from a users Facebook account. It provides an image picker interface that matches the iOS SDK's UIImagePickerController.
https://www.kite.ly
MIT License
103 stars 56 forks source link

Upgrade to Facebook SDK 4.0 #2

Closed julien-c closed 8 years ago

julien-c commented 9 years ago

Hi,

I'd be willing to look into upgrading the FB SDK to 4.0 if you'd be ok with it.

I'm not sure at this point whether the upgrade would mean changing many things or not (but I suspect not). See the high-level changelog here: https://developers.facebook.com/docs/ios/upgrading-4.x

Any thoughts?

Cheers!

dbotha commented 9 years ago

Hi Julien,

Wow surprised people are using this before I even got any README up (soon!). Hoping it's working out well for you? Sure please do, I don't think it'd require much change to work with the new API but I've not had the chance to take a peek yet. If you create a pull request I'll happily review and merge.

Thanks

dbotha commented 9 years ago

btw, LOVE circular.io :) :+1: Use it frequently.

julien-c commented 9 years ago

Ha, that's great! :beers:

It worked perfectly once I set up another Facebook app ID (the one included in the project had Facebook complain about Sign-in not being enabled, I believe). By the way I found it while searching Cocoapods for Image Picker. Ok I'll try and give it a go then!

cashmash commented 9 years ago

trust me, more people will use this lib

julien-c commented 9 years ago

I will look into this today or tomorrow @dbotha

dbotha commented 9 years ago

Awesome :) I'm picking up the start of the documentation this weekend so that the library is a little more approachable.

julien-c commented 9 years ago

You're not planning on writing the lib in Swift by the way, are you? :)

dbotha commented 9 years ago

Not on the roadmap just yet, my Swift work has purely been SpriteKit game development related up until recently — need to get educate myself on everything else first :)

On 9 Apr 2015, at 11:50, Julien Chaumond notifications@github.com wrote:

You're not planning on writing the lib in Swift by the way, are you? :)

— Reply to this email directly or view it on GitHub https://github.com/OceanLabs/FacebookImagePicker-iOS/issues/2#issuecomment-91192221.

julien-c commented 9 years ago

See PR in #3

dbotha commented 9 years ago

Hi @julien-c , awesome I'll be taking a look at this sometime over the next few days!

julien-c commented 9 years ago

Great! Let me know if you need any help.

dbotha commented 9 years ago

Hey @julien-c , not forgotten about this - just haven't found the time to do a proper review yet. I'm hoping later this week!

julien-c commented 9 years ago

Sure. Let me know if any help needed!

styrken commented 9 years ago

Hey,

It would be awesome if the PR could be accepted.

Also there seems to be a problem on latest iOS8 (i haven't tested other versions) with loading your .xib files.

dbotha commented 9 years ago

Hey guys, sorry it really is on my list of things to do. I'll try my very best to get it done within the next week.

styrken commented 9 years ago

Great.

I have looked a bit into the PR and @julien-c is missing a rewrite of OLFacebookPhotosForAlbumRequest as well. He only fixed loading the album list.

julien-c commented 9 years ago

Hmm, PhotosForAlbum works for me and I've been running this in production for more than two months now :)

cashmash commented 8 years ago

any update?

dbotha commented 8 years ago

@kkarayannis has done some work to review @julien-c pull request and this should now be complete.