search

OceanLabs / iOS-Print-SDK

iOS Print SDK. Easily add print on demand functionality to your app within minutes! Print Postcards, Magnets, Photo Prints, Posters, Stickers, T-Shirts, PhotoBooks, etc.
https://www.kite.ly
111 stars 33 forks source link

7.0.0: Facebook integration version mismatch and forced inclusion #310

Closed AlexQuinlivan closed 5 years ago

AlexQuinlivan commented 5 years ago

In the previous versions of the SDK, you were able to not include the FBSDKCoreKit and all would be swell.

Since 7.0.0 the Photobooks pod that the SDK depends on pulls in a version of FBSDKCoreKit, this then enables the default Facebook integration for media selection. (I don't want Facebook)

This also introduces an issue where there's a version mismatch on the Facebook dependency as it depends on FBSDKCoreKit (~> 4.33.0) but the print SDK depends on 4.27.1.

This version mismatch is also partly why I'm raising this issue, as it seems that if you use FBSDKCoreKit (~> 4.33.0) with the print SDK, when tapping the login button for the Facebook provider you'll receive a EXC_BREAKPOINT

Is there a way for the sub-pod of Photobooks library to not depend so much on other libraries? Or to at least have the option of removing/replacing those features?

kkarayannis commented 5 years ago

We just released a new version of the Photobook pod that removes the requirement for the FB SDK. Running pod update should pull the new version. The other dependencies are necessary at this time.