OceanNetworksCanada / api-python-client

Provides easy access to ONC data in Python
https://oceannetworkscanada.github.io/api-python-client/
Apache License 2.0
10 stars 9 forks source link

actualSamples is not added when allPages is equal to True in scalardata service #29

Open kan-fu opened 8 months ago

kan-fu commented 8 months ago

allPages=True in scalardata services can concatenate data from multiple pages. However the actualSamples is not summed.

Steps to reproduce:

  1. Run the code snippet below. Without "rowLimit", the json should return 60 files.
    params = {
    "deviceCode": "BPR-Folger-59",
    "dateFrom": "2019-11-23T00:00:00.000Z",
    "dateTo": "2019-11-23T00:01:00.000Z",
    "rowLimit": 25,
    }
    data = onc.getDirectByDevice(params, allPages=True)
    data["sensorData"]

    Expected behavior:

Actual behavior: