Open Jacob-Stevens-Haas opened 1 year ago
Thank you for raising the issue. Just want to give you an update. I bring this topic up in the internal meeting and it is decided that the API call should be more forgiving on the user side. Our developer is working on changing the backend. Hopefully the new feature will be released in the near future.
(created from email ticket)
Description
Some hydrophone acoustic data requires
dpo_hydrophoneDataDiversionMode
, some prohibit it. It's impossible to tell from the API when it's required. This necessitates the workaround of sending the request once within atry
, catching the exception, and then sending the slightly modified request in anexcept
block.Expected behavior
Hydrophones for which
"dpo_hydrophoneDataDiversionMode"
does not apply should accept"OD"
or"All"
. Any other values ("HPF"
,"LPF"
), should give the "no data" response (HTTP 400 w/error code: 33)Actual behavior
Some hydrophones need the
dpo_hydrophoneDataDiversionMode
option, e.g.:Other hydrophones prohibit the option, e.g.:
Discussion
Not the main point but FWIW, the error raised by
_doRequest
should be aValueError
, not the superclassException
.