OceanParcels / Parcels

Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)
https://www.oceanparcels.org
MIT License
295 stars 136 forks source link

Newlines generating errors when installing latest parcels build #1106

Closed nvogtvincent closed 2 years ago

nvogtvincent commented 2 years ago

Steps to reproduce problem:

conda create -n parcels_test -c conda-forge parcels jupyter cartopy ffmpeg
conda activate parcels_test 
conda remove --force parcels
pip install git+https://github.com/OceanParcels/parcels.git@master

Error message:

...

  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-req-build-_hk1hnuh/setup.py", line 8, in <module>
      setup(name='parcels',

...

    File "/home/noam/anaconda3/envs/parcels_test/lib/python3.9/site-packages/setuptools/dist.py", line 151, in single_line
      raise ValueError('Newlines are not allowed')
  ValueError: Newlines are not allowed

Fix: Remove the multiline description in setup.py.

I've reproduced this error (and fix) on two machines, but I don't understand why this error would suddenly be appearing now since I did the same thing without an error around a week ago. Could somebody else see if they can also reproduce this error?

erikvansebille commented 2 years ago

Thanks for reporting, @nvogtvincent. Indeed, this seems to now also pop up on Github Actions, see https://github.com/OceanParcels/parcels/runs/4235078708?check_suite_focus=true#step:3:961.

@CKehl, I've created a PR #1107 to fix this; you may want to also implement this change in #1034 to fix the red-crosses for CI there

erikvansebille commented 2 years ago

By the way, here is the documentation about this change in the description field from setuptools itself: https://github.com/pypa/setuptools/pull/2870